Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc: fix usage with --date #8880

Merged
merged 2 commits into from
Jan 27, 2023
Merged

gc: fix usage with --date #8880

merged 2 commits into from
Jan 27, 2023

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Jan 25, 2023

  • gc --date was broken because the wrong attribute was being accessed resulting in an unexpected exception.
  • --date was being ignored by brancher unless one of --all-branches, --all-tags, --all-commits, --all-experiments was also provided.
  • added test for --date

Originally reported on discord

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 93.39% // Head: 93.40% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c494c79) compared to base (db70d1c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8880   +/-   ##
=======================================
  Coverage   93.39%   93.40%           
=======================================
  Files         453      453           
  Lines       36345    36359   +14     
  Branches     5268     5267    -1     
=======================================
+ Hits        33946    33960   +14     
  Misses       1885     1885           
  Partials      514      514           
Impacted Files Coverage Δ
dvc/repo/brancher.py 100.00% <100.00%> (ø)
dvc/scm.py 86.42% <100.00%> (-0.20%) ⬇️
tests/func/test_gc.py 100.00% <100.00%> (ø)
tests/unit/scm/test_scm.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dtrifiro dtrifiro marked this pull request as ready for review January 25, 2023 16:58
@dtrifiro dtrifiro merged commit 6f0e8a8 into iterative:main Jan 27, 2023
@dtrifiro dtrifiro deleted the fix-gc branch January 27, 2023 11:52
efiop added a commit that referenced this pull request Jan 31, 2023
@efiop efiop mentioned this pull request Jan 31, 2023
efiop added a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants