Custom header for dvc webdav (#8933)Fix https://github.com/iterative/dvc/issues/8931 #8933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederik-sandfort
force-pushed
the
main
branch
from
008fa4d
to
399a147
Compare
frederik-sandfort
force-pushed
the
main
branch
from
399a147
to
2cc5b61
Compare
|
@frederik-sandfort, do you mind bumping the dvc-webdav version to Line 81 in 24023c6 |
Codecov ReportBase: 93.34% // Head: 93.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8933 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 453 453
Lines 36477 36510 +33
Branches 5274 5278 +4
=======================================
+ Hits 34048 34082 +34
+ Misses 1915 1914 -1
Partials 514 514
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@skshetry I updated the dvc-webdav version |
skshetry
approved these changes
Feb 2, 2023
skshetry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skshetry I created a PR for the issue iterative/dvc-webdav#19 (by @conrad-stork) in order to add the possibility of setting a custom auth header. I included schema and tests for dvc. The tests ran fine in the development environment. Additionally, within the environment, the standard dvc functionality (dvc push, dvc pull) with the custom auth header in webdav worked fine. As stated previously, I did not include any version changes.
I also inlcuded a PR for documentation in order to add the functionality to the documentation.
Fix #8931 .
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏