Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repro: Continue on RunCacheNotSupported #9498

Merged
merged 3 commits into from
May 25, 2023
Merged

repro: Continue on RunCacheNotSupported #9498

merged 3 commits into from
May 25, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 23, 2023 •
edited

No description provided.

@daavoo daavoo linked an issue May 23, 2023 that may be closed by this pull request
exp run --pull: keep going even if pull fails #9470
Closed
@daavoo daavoo requested a review from dberenbaum May 23, 2023 14:31
@daavoo daavoo self-assigned this May 23, 2023
@daavoo daavoo added A: pipelines Related to the pipelines feature bugfix fixes bug labels May 23, 2023
daavoo

This comment was marked as outdated.

Sign in to view

@codecov
Copy link

codecov bot commented May 23, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (192c9cc) 91.14% compared to head (a570b94) 91.14%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9498   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files         472      472           
  Lines       36532    36554   +22     
  Branches     5225     5225           
=======================================
+ Hits        33296    33318   +22     
  Misses       2679     2679           
  Partials      557      557
Impacted Files Coverage Δ
dvc/repo/reproduce.py 98.18% <100.00%> (+0.06%) ⬆️
tests/func/test_repro_multistage.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo marked this pull request as draft May 23, 2023 17:21
@daavoo

This comment was marked as outdated.

Sign in to view
@daavoo daavoo marked this pull request as ready for review May 24, 2023 12:57
dberenbaum
dberenbaum reviewed May 24, 2023
View reviewed changes
dvc/repo/reproduce.py Outdated Show resolved Hide resolved
@daavoo daavoo force-pushed the 9470-exp-run-pull-keep-going-even-if-pull-fails branch from 82c025b to 156f221 Compare May 25, 2023 07:32
@daavoo daavoo requested a review from dberenbaum May 25, 2023 07:33
@daavoo daavoo merged commit 5a6f834 into main May 25, 2023
21 checks passed
@daavoo daavoo deleted the 9470-exp-run-pull-keep-going-even-if-pull-fails branch May 25, 2023 14:35
@daavoo daavoo added the backport backport this PR to 2.x branch label May 25, 2023
@mergify mergify bot mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees

@daavoo daavoo

Labels
A: pipelines Related to the pipelines feature backport backport this PR to 2.x branch bugfix fixes bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exp run --pull: keep going even if pull fails
2 participants
@daavoo @dberenbaum