Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: deprecate --file #9547

Merged
merged 1 commit into from
Jun 6, 2023
Merged

add: deprecate --file #9547

merged 1 commit into from
Jun 6, 2023

Conversation

dberenbaum
Copy link
Contributor

Part of #7093

@dberenbaum dberenbaum requested a review from a team June 6, 2023 11:12
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (7863771) 91.03% compared to head (f0a2fa8) 91.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9547      +/-   ##
==========================================
- Coverage   91.03%   91.02%   -0.02%     
==========================================
  Files         472      472              
  Lines       36449    36430      -19     
  Branches     5225     5225              
==========================================
- Hits        33181    33160      -21     
- Misses       2701     2702       +1     
- Partials      567      568       +1     
Impacted Files Coverage Δ
dvc/commands/add.py 90.32% <ø> (-0.31%) ⬇️
tests/func/test_add.py 98.95% <ø> (-0.03%) ⬇️
tests/unit/command/test_add.py 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efiop efiop merged commit 2c43655 into main Jun 6, 2023
19 of 21 checks passed
@efiop efiop deleted the add-file-deprecate branch June 6, 2023 11:57
@skshetry
Copy link
Member

skshetry commented Jun 6, 2023

@dberenbaum, do you mind removing this line as well?

dvc/dvc/repo/add.py

Lines 54 to 55 in 2c43655

if len(targets) > 1 and kwargs.get("file"):
raise InvalidArgumentError("cannot use '--file' with multiple targets")

EDIT: created #9548.

@skshetry skshetry mentioned this pull request Jun 6, 2023
skshetry added a commit that referenced this pull request Jun 6, 2023
Follow up to #9547.
@skshetry skshetry added this to the 3.0 milestone Jun 6, 2023
skshetry added a commit that referenced this pull request Jun 6, 2023
* add: remove `file`

Follow up to #9547.

* Update add.py

* fix tests
@dberenbaum dberenbaum mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants