Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout/fetch: finer control over steps #9601

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Conversation

efiop
Copy link
Member

@efiop efiop commented Jun 14, 2023

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.03 ⚠️

Comparison is base (c827654) 90.53% compared to head (ea3d063) 90.50%.

❗ Current head ea3d063 differs from pull request most recent head 85c2d65. Consider uploading reports for the commit 85c2d65 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9601      +/-   ##
==========================================
- Coverage   90.53%   90.50%   -0.03%     
==========================================
  Files         471      471              
  Lines       36053    36068      +15     
  Branches     5182     5188       +6     
==========================================
+ Hits        32639    32645       +6     
- Misses       2819     2826       +7     
- Partials      595      597       +2     
Impacted Files Coverage Δ
dvc/repo/experiments/executor/base.py 80.31% <ø> (ø)
dvc/repo/imports.py 0.00% <0.00%> (ø)
dvc/repo/worktree.py 9.61% <0.00%> (-0.15%) ⬇️
dvc/repo/checkout.py 93.58% <100.00%> (+0.25%) ⬆️
dvc/repo/fetch.py 95.65% <100.00%> (+0.65%) ⬆️
tests/func/data/db/test_index.py 89.77% <100.00%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efiop efiop force-pushed the dvc-data-2.0 branch 29 times, most recently from fb0e3a9 to f9b5adf Compare June 18, 2023 01:36
@efiop efiop force-pushed the dvc-data-2.0 branch 13 times, most recently from 36ab587 to e8141e3 Compare June 18, 2023 07:00
@efiop efiop force-pushed the dvc-data-2.0 branch 6 times, most recently from a7382bb to ea3d063 Compare June 18, 2023 14:51
For some unknown reason the mock in this test leaks into the outside tests.

I wasn't able to determine why in the reasonable amount of time, so instead just
simplifying it to not use mocker at all.

That whole file should really be migrated to dvc-data, but that needs some time.
@efiop efiop marked this pull request as ready for review June 18, 2023 15:58
@efiop efiop merged commit e16c0c8 into iterative:main Jun 18, 2023
18 of 19 checks passed
@efiop efiop added the ui user interface / interaction label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant