benchmarks: update tests for dvc 3.x #9608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #9608 +/- ##
==========================================
- Coverage 90.52% 90.26% -0.26%
==========================================
Files 471 471
Lines 36048 36048
Branches 5186 5186
==========================================
- Hits 32632 32539 -93
- Misses 2820 2893 +73
- Partials 596 616 +20
β View full report in Codecov by Sentry. |
pmrowla
changed the title
pmrowla
commented
Jun 15, 2023
| @@ -3,7 +3,7 @@ def test_update(bench_dvc, tmp_dir, dvc, make_dataset): | |||
| dataset = make_dataset( | |||
| cache=False, files=True, dvcfile=False, commit=False, remote=False | |||
| ) | |||
| dvc.imp_url(str(dataset), "new") | |||
| bench_dvc("import-url", str(dataset), "new") | |||
There was a problem hiding this comment.
We can't use the dvc fixture for benchmark tests any more. Using dvc-bench with DVC 3.x will generate 3.x .dvc and dvc.lock files that cannot be read in older versions.
What we really need is an equivalent fixture for test setup that uses the venv DVC, but bench_dvc works for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π
Fixes iterative/dvc-bench#461