Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_param: params should be shown in report #315

Closed
dberenbaum opened this issue Sep 28, 2022 · 2 comments · Fixed by #320
Closed

log_param: params should be shown in report #315

dberenbaum opened this issue Sep 28, 2022 · 2 comments · Fixed by #320
Labels
A: log_param Area: `live.log_param`/`live.log_params` A: report Area: `live.make_report` p2-medium

Comments

@dberenbaum
Copy link
Contributor

Not sure if this belongs here or in https://github.com/iterative/dvc-render/, but all the values from {Live.dir}/params.yaml should also be shown in the metrics report.
@dberenbaum dberenbaum added A: report Area: `live.make_report` A: log_param Area: `live.log_param`/`live.log_params` p2-medium labels Sep 28, 2022
@daavoo
Copy link
Contributor

daavoo commented Sep 29, 2022

Not sure if this belongs here or in https://github.com/iterative/dvc-render/

Both

@dberenbaum dberenbaum mentioned this issue Sep 29, 2022
Closed
@daavoo
Copy link
Contributor

daavoo commented Sep 29, 2022 •
edited
Loading

I was mistaken. Forgot that I already added the TableRenderer for metrics. It should be possible to reuse it for displaying parameters:

dvclive/src/dvclive/report.py

Lines 72 to 74 in a4ca09e

TableRenderer(
[json.loads(summary_path.read_text(encoding="utf-8"))],
summary_path.name,

@daavoo daavoo mentioned this issue Oct 3, 2022
Merged
@daavoo daavoo linked a pull request Oct 3, 2022 that will close this issue
report: Add table for params #320
Merged
daavoo added a commit that referenced this issue Oct 3, 2022
@daavoo
report: Add table for params
144e63a 
Refactor `make_report` to accept `Live` instance as unique argument.

Closes #315
daavoo added a commit that referenced this issue Oct 4, 2022
@daavoo
report: Add table for params (#320)
b30803c 
Refactor `make_report` to accept `Live` instance as unique argument.

Closes #315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: log_param Area: `live.log_param`/`live.log_params` A: report Area: `live.make_report` p2-medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

report: Add table for params iterative/dvclive
2 participants
@dberenbaum @daavoo