Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalyst: restrict version #220

Merged
merged 1 commit into from
Feb 14, 2022
Merged

catalyst: restrict version #220

merged 1 commit into from
Feb 14, 2022

Conversation

pared
Copy link
Contributor

@pared pared commented Feb 14, 2022

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

For catalyst==22.02 our builds fail, need to investigate that, restricting the version for now.
Temporary workaround for #219

@pared pared requested a review from daavoo February 14, 2022 13:12
Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start doing this for all frameworks?

@pared
Copy link
Contributor Author

pared commented Feb 14, 2022

@daavoo I think that this is quite a challenge for us to decide.

  1. On one hand we don't want to restrict the dependencies, because that could interfere with users workspace, and dvclive is probably not that important to force user to install particular version of the DL framework.

  2. On the other hand, we need to maintain our project and the wide range of supported frameworks makes it hard to be able to know which versions of particular frameworks we support. Solution to that would be restricting the supported versions, but that contradicts with 1. We can discuss this on our next meeting.

@daavoo daavoo merged commit 124665a into main Feb 14, 2022
@daavoo daavoo deleted the restrict_catalyst branch February 14, 2022 13:55
@pared pared mentioned this pull request Feb 22, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants