Run safety only against real dvclive deps. #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
commented
Sep 28, 2022
| @@ -41,11 +41,9 @@ tests = | |||
| pylint-plugin-utils>=0.6 | |||
| mypy==0.971 | |||
| pandas>=1.3.1 | |||
| funcy>=1.1 | |||
There was a problem hiding this comment.
was just used for a simple random thing in tests
daavoo
force-pushed
the
safety-skip-frameworks
branch
from
78b239f
to
e823f6c
Compare
We don't own ML framework dependencies and it is ML framework responsability to run the safety checks. We will eventually move framework integrations to the framework itself #221
daavoo
force-pushed
the
safety-skip-frameworks
branch
from
046fb1b
to
c12b2b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't own ML framework dependencies and it is the ML framework responsibility to run the safety checks.
We will eventually move framework integrations to the framework itself #221