-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example #697
Update example #697
Conversation
|
Hello there. |
Test failures are unrelated to your changes. I am working on a fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Gema! LGTM. Left 2 minor comments
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
for more information, see https://pre-commit.ci
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
❗ I have followed the Contributing to DVCLive
guide.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Notes
Aims to solve #663
Add sections and key bullet points about what the example does.
Following some of the dynamics from Hugginface notebooks examples
i̵n̵ ̵w̵h̵i̵c̵h̵ ̵c̵o̵n̵f̵i̵g̵u̵r̵a̵t̵i̵o̵n̵ ̵t̵r̵a̵c̵e̵ ̵h̵a̵s̵ ̵b̵e̵e̵n̵ ̵e̵r̵a̵s̵e̵d̵ ̵b̵u̵t̵ ̵M̵L̵ ̵r̵e̵s̵u̵l̵t̵s̵ ̵a̵r̵e̵ ̵s̵h̵o̵w̵n̵.̵ ̵
EDIT : Please see
codespell
limitations in notebooks scenario #2138 that nudged towards submitting the notebook without being executed.Please consider a separate repository with examples or studying the addition of tools like reviewnb.com in repositories that might contain notebooks and might be key for adoption.
Thanks for the time dedicated to reviewing the PR! 🙏