Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example #697

Merged
merged 8 commits into from
Sep 5, 2023
Merged

Update example #697

merged 8 commits into from
Sep 5, 2023

Conversation

SoyGema
Copy link
Contributor

@SoyGema SoyGema commented Sep 1, 2023

Notes

Aims to solve #663

  • Add sections and key bullet points about what the example does.

  • Following some of the dynamics from Hugginface notebooks examples
    i̵n̵ ̵w̵h̵i̵c̵h̵ ̵c̵o̵n̵f̵i̵g̵u̵r̵a̵t̵i̵o̵n̵ ̵t̵r̵a̵c̵e̵ ̵h̵a̵s̵ ̵b̵e̵e̵n̵ ̵e̵r̵a̵s̵e̵d̵ ̵b̵u̵t̵ ̵M̵L̵ ̵r̵e̵s̵u̵l̵t̵s̵ ̵a̵r̵e̵ ̵s̵h̵o̵w̵n̵.̵ ̵

EDIT : Please see codespell limitations in notebooks scenario #2138 that nudged towards submitting the notebook without being executed.
Please consider a separate repository with examples or studying the addition of tools like reviewnb.com in repositories that might contain notebooks and might be key for adoption.

Thanks for the time dedicated to reviewing the PR! 🙏

@SoyGema
Copy link
Contributor Author

SoyGema commented Sep 1, 2023

  • Test core not pass : related to studio ?
    - Tried : sync with last release
  • code spell issues with NOTEBOOK executed: prob misspelling . Tried
    - Install locally codespell. Pass notebook. Same error was displayed.
    - Convert jupyter notebook to script with nbconvert to find exact cells (Only line-code counts as number) and pass codespell. None of the typos were found.
    - Activate Toogle Notebook VSCode Line numbers -Numbers restart on each cell- No backtrace of misspelling was possible
    - Canonical search in VSCode command+f
    - Review general with the tool HF&NASA are using for reviewing Notebooks
    - Review codespell conversion scenario. Apparently codespell #2138 checks also in the printed cell.

@SoyGema
Copy link
Contributor Author

SoyGema commented Sep 2, 2023

Hello there.
Ultimately, I´ve submitted the Notebook without being executed.

@SoyGema SoyGema marked this pull request as ready for review September 2, 2023 18:06
@daavoo daavoo self-requested a review September 4, 2023 15:58
@daavoo daavoo added A: frameworks Area: ML Framework integration A: docs Area: user documentation labels Sep 4, 2023
@daavoo
Copy link
Contributor

daavoo commented Sep 4, 2023

Test core not pass : related to studio ?

Test failures are unrelated to your changes. I am working on a fix

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Gema! LGTM. Left 2 minor comments

@codecov-commenter
Copy link

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@daavoo daavoo merged commit 00ddc96 into iterative:main Sep 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation A: frameworks Area: ML Framework integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants