studio: add subdir to live metrics post messages to support live experiments in monorepos #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 95.51% 95.53% +0.02%
==========================================
Files 55 55
Lines 3542 3559 +17
Branches 317 319 +2
==========================================
+ Hits 3383 3400 +17
Misses 111 111
Partials 48 48 ☔ View full report in Codecov by Sentry. |
2 tasks
dberenbaum
added
the
⌛ status: wait-core-merge
mattseddon
force-pushed
the
add-live-subdir
branch
3 times, most recently
from
5d336e6
to
20deaad
Compare
AlexandreKempf
suggested changes
Feb 16, 2024
mattseddon
force-pushed
the
add-live-subdir
branch
from
20deaad
to
4c5c143
Compare
mattseddon
removed
the
⌛ status: wait-core-merge
AlexandreKempf
approved these changes
Feb 21, 2024
dberenbaum
approved these changes
Feb 21, 2024
…riments in monorepos
mattseddon
force-pushed
the
add-live-subdir
branch
from
4c5c143
to
351bbcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVCLive guide.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Part of https://github.com/iterative/studio/issues/8848
Repeat of #779 but stripped back to only send subdir.
Depends on iterative/dvc-studio-client#154 / https://github.com/iterative/studio/pull/9173 /iterative/dvc#10303