Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to define CA certificates #16

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Add support to define CA certificates #16

merged 2 commits into from
Jan 10, 2023

Conversation

mjasion
Copy link
Contributor

@mjasion mjasion commented Dec 16, 2022 •
edited
Loading

Closes #5

Allow defining CA certificate, which will be installed in Pod containers. The previous implementation were proposing to bake certificates into a docker image.

New approach sets internal libraries to use system trust store, OpenSSL (/etc/ssl/certs), installed by ca-certificates package, and later updated by update-ca-certificates command executed in docker-entrypoint.sh.

Related PR: iterative/studio-selfhosted#19

@mjasion mjasion added the enhancement New feature or request label Dec 16, 2022
@mjasion mjasion requested a review from jesper7 December 16, 2022 17:26
@mjasion mjasion self-assigned this Dec 16, 2022
@mjasion mjasion marked this pull request as draft December 16, 2022 17:26
@mjasion mjasion changed the title 5 add support for custom root ca certificate Add support to define CA certificates Dec 16, 2022
@mjasion mjasion marked this pull request as ready for review December 16, 2022 17:26
@mjasion mjasion marked this pull request as draft December 16, 2022 17:27
@mjasion mjasion requested a review from a team December 19, 2022 06:44
jesper7
jesper7 suggested changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@jesper7 jesper7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 🥳

charts/studio/templates/configmap.yaml Outdated Show resolved Hide resolved
charts/studio/templates/configmap.yaml Outdated Show resolved Hide resolved
charts/studio/templates/deployment-studio-backend.yaml Outdated Show resolved Hide resolved
charts/studio/values.yaml Outdated Show resolved Hide resolved
@mjasion mjasion force-pushed the 5-add-support-for-custom-root-ca-certificate branch 3 times, most recently from 10759d1 to c0895b5 Compare January 3, 2023 20:44
@mjasion mjasion force-pushed the 5-add-support-for-custom-root-ca-certificate branch from c0895b5 to ce55b80 Compare January 3, 2023 20:55
jesper7
jesper7 previously approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@jesper7 jesper7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling it ❤️

charts/studio/templates/configmap.yaml Outdated Show resolved Hide resolved
charts/studio/templates/deployment-studio-backend.yaml Outdated Show resolved Hide resolved
charts/studio/templates/deployment-studio-beat.yaml Outdated Show resolved Hide resolved
charts/studio/templates/deployment-studio-ui.yaml Outdated Show resolved Hide resolved
charts/studio/templates/deployment-studio-worker.yaml Outdated Show resolved Hide resolved
@jesper7 jesper7 marked this pull request as ready for review January 4, 2023 12:36
@mjasion mjasion merged commit 2d36d9d into main Jan 10, 2023
@mjasion mjasion deleted the 5-add-support-for-custom-root-ca-certificate branch January 10, 2023 13:37
@mjasion mjasion mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesper7 jesper7 jesper7 approved these changes

Assignees

@mjasion mjasion

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for custom root CA certificate
2 participants
@mjasion @jesper7