Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor values.yaml, document each variable #28

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Refactor values.yaml, document each variable #28

merged 3 commits into from
Jan 12, 2023

Conversation

jesper7
Copy link
Contributor

@jesper7 jesper7 commented Jan 11, 2023

Changes:

  • Refactor values.yaml to make the configuration more simple
  • Document each variable according to Helm best practices

@jesper7 jesper7 requested a review from mjasion January 11, 2023 13:56
@jesper7 jesper7 self-assigned this Jan 11, 2023
@jesper7 jesper7 marked this pull request as draft January 11, 2023 13:56
@jesper7 jesper7 marked this pull request as ready for review January 11, 2023 15:42
@jesper7 jesper7 merged commit 586bfeb into iterative:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjasion mjasion mjasion approved these changes

Assignees

@jesper7 jesper7

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesper7 @mjasion