README: Fix secret, create namespace #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omesser
force-pushed
the
readme_secret_in_ns
branch
2 times, most recently
from
1d25776
to
c8864b9
Compare
omesser
force-pushed
the
readme_secret_in_ns
branch
from
c8864b9
to
df149ab
Compare
omesser
changed the title
jesper7
previously requested changes
Jan 13, 2023
jesper7
added
documentation
jesper7
changed the title
|
Updated the PR title so that we can start having a consistent format for README changes in the changelog |
mjasion
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the charts are installed in
studionamespace, thedocker-registrysecret needs to be there too (otherwise referencing it the way we do doesn't work, and it should be there anyways).