This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Show docs on navbar on mobile view #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
reviewed
Jun 30, 2022
There was a problem hiding this comment.
Thanks for spotting this! While we'll probably want to look into an alternative way that makes things less cramped, this is better than it not existing at all!
The only problem I see is that things overflow in the smallest of screen sizes which can be fixed pretty easily (see comment) :)
rogermparent
approved these changes
Jun 30, 2022
julieg18
approved these changes
Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making docs link on navbar visible on mobile view. This is just a quick solution to at least have mobile users easy access to docs and can easily be replaced later. There are better approaches and can be discussed #117 further.