add support for 3.12 #149
add support for 3.12 #149
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 84.15% 84.15%
=======================================
Files 12 12
Lines 385 385
Branches 51 50 -1
=======================================
Hits 324 324
Misses 52 52
Partials 9 9 ☔ View full report in Codecov by Sentry. |
src/pytest_servers/factory.py
Outdated
| _ = str(path) # force Path to compute `Path._str` | ||
| path._str = path._str.rstrip("/") # remove trailing slash |
There was a problem hiding this comment.
upath now returns a new instance of accessor each time you access those. Also, UPath._accessor usage is now deprecated, although it is what is used internally.
I haven't found a correct place to fix this without extending, as
Upath.path are properties that just ask Pathlib.path which in turn just calls __str__ (which is adding a trailing slash to it).
Ideally, gcfs should support a path with a trailing slash, but Upath should not add a trailing slash when it's not provided either. I'll try to create an issue on both repositories.
There was a problem hiding this comment.
Thanks @skshetry, can you add a note here pointing to those issues?
There was a problem hiding this comment.
Okay, looking at s3fs, it does not handle s3fs.info("bucket/") or s3fs.info("bucket") either. It raises FileNotFoundError in both cases.
However, it does magically work with _exists() due to a separate implementation.
As we already do .mkdir(), the bucket is created. So I don't think we should try to support something that is not supported by gcsfs at all.
The users of this library need not worry about whether the bucket is created or not. I'm skipping this ugly workaround for now.
skshetry
force-pushed
the
3.12
branch
2 times, most recently
from
b71eebd
to
01c2e05
Compare
requires `universal-pathlib>=0.2.0`
Testing for fsspec/universal_pathlib#173.