add tmp_upath_factory fixture #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
force-pushed
the
add-make-tmp-upath
branch
from
24b13e4
to
738bed7
Compare
efiop
reviewed
Jun 25, 2022
efiop
reviewed
Jun 25, 2022
efiop
reviewed
Jun 25, 2022
efiop
reviewed
Jun 25, 2022
Comment on lines
25
to
+34
| self.proc = subprocess.Popen( | ||
| shlex.split("moto_server s3 -p %s" % self.port) | ||
| shlex.split( | ||
| f"moto_server s3 -p {self.port}", | ||
| ), | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE, |
There was a problem hiding this comment.
Looks like we are seriously polluting your machine ports, which will turn ugly. Take a look at how we do it in dvc - we spawn one container with moto (and azurite in the future, for example) to simulate real s3 and we use a random single port without polluting.
There was a problem hiding this comment.
There was a problem hiding this comment.
If we at least don't spam lots of servers - this will become minor 🙂
There was a problem hiding this comment.
Added an optional flag (--moto-server) to set a custom port. In #13 I introduce a docker fixture which can be used to spawn docker containers. I will introduce some proper port management after that.
dtrifiro
force-pushed
the
add-make-tmp-upath
branch
from
da36b78
to
786ce5d
Compare
dtrifiro
force-pushed
the
add-make-tmp-upath
branch
2 times, most recently
from
a206a50
to
06595c6
Compare
efiop
reviewed
Jun 29, 2022
dtrifiro
force-pushed
the
add-make-tmp-upath
branch
from
06595c6
to
9360d7b
Compare
dtrifiro
force-pushed
the
add-make-tmp-upath
branch
from
9360d7b
to
474bbea
Compare
Merged
efiop
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.