subcommand convenience wrapper doesn't work

[casperdcl]

shtab/examples/customcomplete.py

Line 43 in a01e2b5

shtab.add_argument_to(parser, "shell") # magic!

provides completion only for the subparser rather than the full (parent) parser

[shcheklein]

@casperdcl curious, what is the use case here, could you give an example please?

[casperdcl]

basically the https://github.com/iterative/shtab/blob/a01e2b592102496a3a7b6861b448d0d6e78407f4/examples/customcomplete.py demo doesn't work - the generated completions only complete one subcommand (customcomplete completion ...) rather than the root command (customcomplete ...).

With #26 (correct convenience function), we can probably halve the number of lines in https://github.com/iterative/dvc/blob/master/dvc/command/completion.py

[shcheklein]

so, DVC is not affected at the moment?

[casperdcl]

no, not affected because it isn't (yet) using this convenience function. Merging #26 also won't affect dvc.

A PR in dvc can be made after merge to benefit.

[shcheklein]

@casperdcl got it, thanks! 🙏 (that's why it was hard to get the idea, since I was trying it on the DVC and was not seeing any issues).