-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix CI, misc minor updates #131
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 91.36% 91.36%
=======================================
Files 3 3
Lines 336 336
=======================================
Hits 307 307
Misses 29 29 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Oh woe is me, |
@@ -1,5 +1,5 @@ | |||
mkdocs-material | |||
git+https://github.com/iterative/jsmin@python3-only#egg=jsmin | |||
git+https://github.com/tqdm/jsmin@python3-only#egg=jsmin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume someone deleted iterative's jsmin
fork, causing the docs build to fail here.
In any case 'tis the same as the tqdm fork.
/gripe in future should really have better basic checks before deleting repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in future should really have better basic checks before deleting repo
Yeah 100% agree. Hopefully this would be in the actual repo's description - if it's a dependency of some other project, should be noted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the jsmin
repository deletion. I haven't found any occurrence in Slack and it was probably accidental, as part of some organization cleanup effort. 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @casperdcl ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -1,5 +1,5 @@ | |||
mkdocs-material | |||
git+https://github.com/iterative/jsmin@python3-only#egg=jsmin | |||
git+https://github.com/tqdm/jsmin@python3-only#egg=jsmin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the jsmin
repository deletion. I haven't found any occurrence in Slack and it was probably accidental, as part of some organization cleanup effort. 🙈
No description provided.