Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI, misc minor updates #131

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix CI, misc minor updates #131

merged 1 commit into from
Mar 16, 2023

Conversation

casperdcl
Copy link
Collaborator

No description provided.

@casperdcl casperdcl added testing Unit tests & debugging technical-debt Refactoring, linting & tidying labels Mar 16, 2023
@casperdcl casperdcl self-assigned this Mar 16, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (779a4db) 91.36% compared to head (7b7d774) 91.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files           3        3           
  Lines         336      336           
=======================================
  Hits          307      307           
  Misses         29       29           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@casperdcl
Copy link
Collaborator Author

Oh woe is me,
sans admin perms -
thou must approve
before I can merge

@@ -1,5 +1,5 @@
mkdocs-material
git+https://github.com/iterative/jsmin@python3-only#egg=jsmin
git+https://github.com/tqdm/jsmin@python3-only#egg=jsmin
Copy link
Collaborator Author

@casperdcl casperdcl Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume someone deleted iterative's jsmin fork, causing the docs build to fail here.
In any case 'tis the same as the tqdm fork.

/gripe in future should really have better basic checks before deleting repos.

Copy link
Contributor

@omesser omesser Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in future should really have better basic checks before deleting repo

Yeah 100% agree. Hopefully this would be in the actual repo's description - if it's a dependency of some other project, should be noted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the jsmin repository deletion. I haven't found any occurrence in Slack and it was probably accidental, as part of some organization cleanup effort. 🙈

.github/workflows/test.yml Show resolved Hide resolved
Copy link
Contributor

@omesser omesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @casperdcl ❤️

@omesser omesser merged commit 1eb80f6 into main Mar 16, 2023
@omesser omesser deleted the devel branch March 16, 2023 17:09
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -1,5 +1,5 @@
mkdocs-material
git+https://github.com/iterative/jsmin@python3-only#egg=jsmin
git+https://github.com/tqdm/jsmin@python3-only#egg=jsmin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the jsmin repository deletion. I haven't found any occurrence in Slack and it was probably accidental, as part of some organization cleanup effort. 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Refactoring, linting & tidying testing Unit tests & debugging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants