Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc zsh fixes #93

Merged
merged 5 commits into from
Nov 18, 2022
Merged

misc zsh fixes #93

merged 5 commits into from
Nov 18, 2022

Conversation

Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Aug 28, 2022 •
edited by casperdcl
Loading

@sourcery-ai

This comment was marked as off-topic.

Sign in to view
@sourcery-ai sourcery-ai bot mentioned this pull request Aug 28, 2022
Closed
casperdcl
casperdcl requested changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@casperdcl casperdcl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(oops sorry wrong review)

@casperdcl casperdcl added the technical-debt Refactoring, linting & tidying label Oct 26, 2022
@casperdcl casperdcl self-assigned this Oct 26, 2022
@casperdcl casperdcl self-requested a review October 26, 2022 21:49
casperdcl
casperdcl requested changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Sorry for the delay.

shtab/__init__.py Outdated Show resolved Hide resolved
@casperdcl casperdcl linked an issue Oct 26, 2022 that may be closed by this pull request
[bug] shtab's --print-completion should stop completion #92
Closed
@casperdcl casperdcl added enhancement New feature or request shell-zsh and removed technical-debt Refactoring, linting & tidying labels Oct 26, 2022
@casperdcl casperdcl removed their assignment Oct 26, 2022
@casperdcl casperdcl added the external-request You asked, we did label Oct 26, 2022
casperdcl
casperdcl requested changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo

shtab/__init__.py Outdated Show resolved Hide resolved
shtab/__init__.py Outdated Show resolved Hide resolved
@casperdcl
Copy link
Collaborator

@Freed-Wu Thanks! You wrote fixes #91 in a commit message, just clarifying you meant fixes #90, right?

@Freed-Wu
Copy link
Contributor Author

@Freed-Wu Thanks! You wrote fixes #91 in a commit message, just clarifying you meant fixes #90, right?

It also fix #91, which path completion failed in zsh. Because they are simple, I put them in one PR. If you like, I can split them to many PRs.

@casperdcl casperdcl linked an issue Nov 18, 2022 that may be closed by this pull request
[bug] pathcomplete.py cannot complete file for zsh #91
Closed
@casperdcl casperdcl changed the title Fix #92 misc zsh fixes Nov 18, 2022
Freed-Wu and others added 5 commits November 18, 2022 22:08
@Freed-Wu @casperdcl
Add _PrintCompletionAction to OPTION_END, Fix #92
16bfdb7 
Change `(- :)` to `(- : *)` for zsh
@Freed-Wu @casperdcl
Add REMAINDER for is_opt_end()
ebf4ec3
@Freed-Wu @casperdcl
Add support for REMINDER, Fix #91
8f1397e 
Add format_positional(opt) to all_commands and change zsh template to fix #91, and use argparse.{ONE_OR_MORE, ZERO_OR_MORE, REMAINDER} to replace raw string
@casperdcl
some tidy
95b0e30
@casperdcl
update tests
a23f6f6
casperdcl
casperdcl approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@casperdcl casperdcl merged commit 6779de6 into iterative:main Nov 18, 2022
@casperdcl
Copy link
Collaborator

/tag v1.5.8 6779de6

@Freed-Wu Freed-Wu deleted the master branch November 19, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@Freed-Wu Freed-Wu

Labels
enhancement New feature or request external-request You asked, we did shell-zsh
Projects
None yet
Milestone
No milestone
2 participants
@Freed-Wu @casperdcl