Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark resource_runner token as sensitive #120

Merged
merged 2 commits into from
May 31, 2021
Merged

Mark resource_runner token as sensitive #120

merged 2 commits into from
May 31, 2021

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented May 26, 2021 •
edited
Loading

Related to iterative/cml#564

@0x2b3bfa0 0x2b3bfa0 added p1-important High priority security Sensitive flaws labels May 26, 2021
@0x2b3bfa0 0x2b3bfa0 self-assigned this May 26, 2021
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request May 26, 2021
Merged
@restyled-io restyled-io bot mentioned this pull request May 26, 2021
Merged
@restyled-io @restyled-commits
Restyled by gofmt (#121)
ae3eacf 
Co-authored-by: Restyled.io <commits@restyled.io>
DavidGOrtega
DavidGOrtega approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
awesome. It's going to print back another value?

@0x2b3bfa0
Copy link
Member Author

It will mask the output of commands like terraform plan and terraform apply so the value gets replaced, literally, with (sensitive value)

@0x2b3bfa0 0x2b3bfa0 merged commit 88f2162 into master May 31, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the mark-resource-runner-sensitive branch May 31, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGOrtega DavidGOrtega DavidGOrtega approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
p1-important High priority security Sensitive flaws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x2b3bfa0 @DavidGOrtega