Exclude error from successful analytics #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasdomas
reviewed
Oct 26, 2022
| "extra": extra, | ||
| } | ||
|
|
||
| if e != nil { | ||
| payload["error"] = reflect.TypeOf(e).String() |
There was a problem hiding this comment.
Why are we including the string representation of the error's type here? Is that the intent?
There was a problem hiding this comment.
Yes, the goal is providing some information about the error type but not exfiltrating sensitive information
There was a problem hiding this comment.
ah, that would be an absolutely brilliant comment to add at line 352 :)
There was a problem hiding this comment.
It looks like we have some brilliant review comments at #493 (comment) 😄
There was a problem hiding this comment.
Suggested change
| payload["error"] = reflect.TypeOf(e).String() | |
| // Get the type of the error as a string, but not the error message itself, because it can be sensitive. | |
| payload["error"] = reflect.TypeOf(e).String() |
There was a problem hiding this comment.
couldn't resist
Suggested change
| payload["error"] = reflect.TypeOf(e).String() | |
| // only use error type (not message) to avoid potentially sensitive info | |
| payload["error"] = reflect.TypeOf(e).String() |
tasdomas
approved these changes
Oct 26, 2022
| "extra": extra, | ||
| } | ||
|
|
||
| if e != nil { | ||
| payload["error"] = reflect.TypeOf(e).String() |
There was a problem hiding this comment.
ah, that would be an absolutely brilliant comment to add at line 352 :)
Co-authored-by: Helio Machado <0x2b3bfa0+git@googlemail.com>
dacbd
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #703; @casperdcl invenit