Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add structure for passing hardcoded credentials to task #722

Merged
merged 1 commit into from Nov 18, 2022
Merged

Add structure for passing hardcoded credentials to task #722

merged 1 commit into from Nov 18, 2022

Conversation

tasdomas
Copy link
Contributor

@tasdomas tasdomas commented Nov 18, 2022 •
edited by 0x2b3bfa0

Credit: Helio

Edit by @0x2b3bfa0: this pull request is a cherry-pick of #710 to master

@tasdomas tasdomas temporarily deployed to automatic November 18, 2022 11:57 Inactive
@0x2b3bfa0 0x2b3bfa0 changed the title Add structure for passing hardcoded credentials to task. Add structure for passing hardcoded credentials to task Nov 18, 2022
@0x2b3bfa0 0x2b3bfa0 self-requested a review November 18, 2022 11:58
@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request cloud-common Applies to every cloud vendor labels Nov 18, 2022
@0x2b3bfa0 @tasdomas
Add structure for passing hardcoded credentials to task.
15b0ae2 
Co-authored-by: Domas Monkus <domas@iterative.ai>
0x2b3bfa0
0x2b3bfa0 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 18, 2022 12:06 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 18, 2022 12:06 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic November 18, 2022 12:06 Inactive
@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) November 18, 2022 12:07
@0x2b3bfa0 0x2b3bfa0 merged commit 85645f4 into master Nov 18, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the d032-credentials-cherry-pick branch November 18, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees

@tasdomas tasdomas

@0x2b3bfa0 0x2b3bfa0

Labels
cloud-common Applies to every cloud vendor enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tasdomas @0x2b3bfa0