Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve machine identifier format #726

Merged
merged 1 commit into from Dec 1, 2022
Merged

Improve machine identifier format #726

merged 1 commit into from Dec 1, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Dec 1, 2022 •
edited by casperdcl

The only ™️ way of doing it

@0x2b3bfa0 0x2b3bfa0 requested a review from a team December 1, 2022 00:44
@0x2b3bfa0 0x2b3bfa0 self-assigned this Dec 1, 2022
@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request resource-runner iterative_runner TF resource resource-machine iterative_machine TF resource external-request You asked, we did cloud-aws Amazon Web Services cloud-az Microsoft Azure cloud-gcp Google Cloud labels Dec 1, 2022
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review December 1, 2022 00:46
dacbd added a commit to iterative/cml that referenced this pull request Dec 1, 2022
@dacbd
Default cml change paired with (iterative/terraform-provider-iterativ…
d4fa9fa 
…e#726)
dacbd
dacbd approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contingent on: iterative/cml#1265

@0x2b3bfa0 0x2b3bfa0 merged commit c681e1e into master Dec 1, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the human-readable-names branch December 1, 2022 14:56
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Dec 1, 2022
Merged
0x2b3bfa0 pushed a commit to iterative/cml that referenced this pull request Dec 1, 2022
@dacbd
Default cml change paired with (iterative/terraform-provider-iterativ…
eef7c98 
…e#726) (#1265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasdomas tasdomas tasdomas approved these changes

@dacbd dacbd dacbd approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
cloud-aws Amazon Web Services cloud-az Microsoft Azure cloud-gcp Google Cloud enhancement New feature or request external-request You asked, we did resource-machine iterative_machine TF resource resource-runner iterative_runner TF resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x2b3bfa0 @tasdomas @dacbd