Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder: Needs design #175

Closed
13 tasks done
mattseddon opened this issue Mar 17, 2021 · 13 comments
Closed
13 tasks done

Placeholder: Needs design #175

mattseddon opened this issue Mar 17, 2021 · 13 comments
Assignees
Labels
🎨 design Needs design input or is being actively worked on discussion

Comments

@mattseddon
Copy link
Member

mattseddon commented Mar 17, 2021

From the VS Code planning meeting on March 17 (AEDT):

This issue is designed to be a collection point for all of the problems that encounter that will need design input.

The idea is that this should help us to communicate asynchronously with @yalozhkin.

@rogermparent please drop anything that you come across in here.

@yalozhkin let me know what you'd like to see in here.

Thanks!


@rogermparent
Copy link
Contributor

From #170

We'll probably want to use some of the VSCode-injected CSS variables like --vscode-font-family, --vscode-font-weight, and --vscode-editor-font-family so we use the user's configured fonts- doing so allows us to integrate our webviews with the user's VSCode and take advantage of the fonts provided to us as a free resource.

I'm thinking since the --vscode-font-family is generally sans serif and --vscode-editor-font-family monospace, we can use the former for UI elements and the latter for the table.
This concern relates to #175 as well.

Designing with the idea of user-configurable fonts in mind could prove difficult, but I believe the advantages would be worth it.

@mattseddon
Copy link
Member Author

From #158: When we initially open the Experiments webview the panel it is opened in the second editor column of the IDE. We need to decide on what the UI/UX should be for opening this view.

This comment goes into a bit more detail.

@yalozhkin

This comment has been minimized.

@yalozhkin

This comment has been minimized.

@shcheklein

This comment has been minimized.

@shcheklein shcheklein added the 🎨 design Needs design input or is being actively worked on label Mar 18, 2021
@shcheklein shcheklein changed the title Needs Design Placeholder: Needs design Apr 27, 2021
@mattseddon

This comment has been minimized.

@rogermparent

This comment has been minimized.

@mattseddon
Copy link
Member Author

We will need to replicate and implement the design for light themes (currently only catering for dark themes), I have added a checkbox to our release checklist as well 👍🏻 .

@mattseddon mattseddon mentioned this issue Jul 9, 2021
30 tasks
@mattseddon
Copy link
Member Author

We need a design for how we are going to handle experiment data errors within the extension. Current they are shown like this in the cli table: iterative/dvc#5984 (comment)

The issue that we are working off for this is #662.

@mattseddon
Copy link
Member Author

mattseddon commented Jul 23, 2021

Discovered whilst working on #658 in #673 (comment):

Screen Shot 2021-07-19 at 7 16 36 PM

We can only show one icon per tree item. That means that an eye AND a coloured dot is not possible for experiments within the tree view. How could we approach this differently?

Coloured eyes would be my suggestion. Here is a dodgy mockup:
Screen Shot 2021-07-23 at 3 30 22 PM

Relates to #496 (comment)

@mattseddon
Copy link
Member Author

From the Nov 4/5 retro: We need designs of UI/UX for the empty state in the plots webview. See #1000 for the initial discussion.

@mattseddon
Copy link
Member Author

@yalozhkin when you get a chance can you please look at https://github.com/microsoft/vscode-webview-ui-toolkit and see if there is anything that we can incorporate into our design. Thanks

@mattseddon
Copy link
Member Author

We no longer need this placeholder as everything is actively being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Needs design input or is being actively worked on discussion
Projects
None yet
Development

No branches or pull requests

5 participants