Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update converters #34

Merged
merged 22 commits into from
Aug 23, 2016
Merged

Update converters #34

merged 22 commits into from
Aug 23, 2016

Conversation

AIAitesla
Copy link
Contributor

The Macroblock converter and the exporter to Modelica have been updated to the changes in the iPSL.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 24.939% when pulling a77201c on AIAitesla:master into a8af22f on itesla:master.

@@ -9,10 +9,7 @@
import java.util.ArrayList;
import java.util.List;

/**
* Single block of the Eurostag macroblock
* @author Marc Sabate <sabatem@aia.es>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author is removed?

@mathbagu
Copy link
Contributor

Hello,
Could you please fix / check these topics:

  • use 4 spaces instead of tabs for indentation
  • translate spanish comments in english
  • file encoding issue (in spanish comment) : declaración / declaración
  • empty lines or trailing spaces
  • ensure that comment code bloc should be kept (GeneratorRecord.java)?

In test case "EU2Mod_MB/src/test/java/itesla/test/iTesla.java" some pathes are hard-coded. I think it could be better to add resources in source tree to perform automatic test case with coveralls, if possible?

In "modelica-export/src/main/java/eu/itesla_project/modelica_export/records/GeneratorRecord.java", lot of code is commented: could this code be removed or not?

I tried to add note in code to help you...

Regards,
Mathieu

Add authors information
Add authors information
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 25.728% when pulling f456223 on AIAitesla:master into a8af22f on itesla:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 25.728% when pulling f456223 on AIAitesla:master into a8af22f on itesla:master.

Add author information and remove empty lines.
Add authors info, remove empty lines and translate comments.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 25.724% when pulling 55a4161 on AIAitesla:master into a8af22f on itesla:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 25.728% when pulling 55a4161 on AIAitesla:master into a8af22f on itesla:master.

Add authors info, remove empty lines and translate comments.
Add author info, remove empty lines, spaces and fix identation issues.
Remove hardcoded paths and empty lines.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 25.724% when pulling e2aba17 on AIAitesla:master into a8af22f on itesla:master.

REmove empty lines, spaces and remove comments.
Remove empty lines and translate comments
Remove empty lines, spaces and translate comments.
Remove hard-coded pathes
@AIAitesla
Copy link
Contributor Author

Hello,

Thank you very much for the comments.
We have fixed/check those you have notified us. We will check the rest of the code soon,

Regards.

@AIAitesla AIAitesla closed this Jul 22, 2016
@AIAitesla AIAitesla reopened this Jul 22, 2016
@mathbagu mathbagu mentioned this pull request Jul 23, 2016
Add missing dependency
Solve missing symbol error.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 25.736% when pulling db5f73b on AIAitesla:master into a8af22f on itesla:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 25.73% when pulling dbce7c2 on AIAitesla:master into 1bdddf4 on itesla:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 25.73% when pulling 3cf9fb8 on AIAitesla:master into 394ec43 on itesla:master.

Fix name error: delete a whitespace
Fix nam error: change a dash
@coveralls
Copy link

Coverage Status

Coverage remained the same at 25.726% when pulling 2f1c6bb on AIAitesla:master into 394ec43 on itesla:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 25.734% when pulling 2f1c6bb on AIAitesla:master into 394ec43 on itesla:master.

@mathbagu mathbagu merged commit e005daa into itesla:master Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants