Skip to content

Commit

Permalink
Hide invoice ticket button for techs
Browse files Browse the repository at this point in the history
  • Loading branch information
@wrongecho
wrongecho committed Dec 28, 2022
1 parent ea3a12b commit 6df24d8
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions ticket.php
View file
Expand Up @@ -589,12 +589,17 @@

<?php if($config_module_enable_accounting){ ?>
<div class="card card-body card-outline card-dark mb-2">
<div class="">
<a href="#" class="btn btn-outline-success btn-block" href="#" data-toggle="modal" data-target="#addInvoiceFromTicketModal">Invoice Ticket</a>
<div>
<?php
if($_SESSION['user_role'] == 1 || $_SESSION['user_role'] == 3){
?>
<a href="#" class="btn btn-outline-success btn-block" href="#" data-toggle="modal" data-target="#addInvoiceFromTicketModal">Invoice Ticket</a>
<?php } ?>

<?php
if($ticket_status !== "Closed"){
?>
<a href="post.php?close_ticket=<?php echo $ticket_id; ?>" class="btn btn-outline-danger btn-block">Close Ticket</a>
<a href="post.php?close_ticket=<?php echo $ticket_id; ?>" class="btn btn-outline-danger btn-block">Close Ticket</a>
<?php } ?>
</div>
</div>
Expand Down

6 comments on commit 6df24d8

@aftechro
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave the invoice button active for the techs, especially if they are dealing with something that`s not included in the support agreement, such as applying new type of O365 subscription, changing pc parts and so on and maybe have the admin role to check the invoice before sending to the customer. at the and of the day, the techs are the ones who are dealing mostly with the customers and the admin is focusing on other aspects of the business if you get me :D So strongly recommend to put leave it active for technicians

@wrongecho
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aftechro. Hope you had a good Christmas!

My reasoning behind hiding this for technicians were based on the access matrix that was previously agreed upon with @johnnyq. We took the view that technicians should have no access to the sales area of ITFlow - only admins and accountants. It's worth mentioning that I have further work planned to completely block the technician's access to invoicing/accounting altogether. For example, we recently had an issue raised where someone (rightly so) didn't like that techs could see the business financials on the main dashboard.

I guess whether techs generate/edit/send invoices in your example would be very dependent on your business process - in my MSP we had dedicated account managers that took care of these things. Though now as I'm writing this I'm aware that a) ITFlow is aimed at small MSPs and b) we don't have such a role that fits this specifically. It might be worth sharing your ideas with Johnny (I've already tagged him) to see what his thoughts are on this and if he's open to changing the matrix/roles.

@aftechro
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, you can hide the income and account aspects of a business from the technician and other roles, i`m totally agree with that, but in hiding invoicing option for tech, means that the admin, have to waste time in looking trough all the tickets and see if they were invoiced correctly or not. What we have, when a user will create an invoice, the invoice is going as draft, the admin is notified, admin can then check the ticket connected to the invoice and decide if invoice would be sent or removed. but for the MSP, mostly the technicians are the ones who do the jobs and invoice accordingly that brings the income to the business :D and would be much handier and logically to do it so :D

@wrongecho
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accounting and "Sales" (quotes and invoicing) were both going to be hidden under the matrix.

I disagree with the idea of having a draft and approval process. I think we need to either decide that techs a) have full access to sales functionality or b) they have none.
We can't do half-measures of giving them access to generate and edit invoices but not send or delete them - I think that'd just cause more issues than anything. Either they take full ownership of the process, or they write the details as an internal note and pass it to an admin to be invoiced before being closed.

Note that none of these options save the admin any time spent "checking" things in my view. Either you trust all your techs to work on invoicing (full access/ownership) or you don't (leave it to the admin). It'd be great if it was configurable, but we're not at that stage of being able to customize roles/permissions.

@aftechro
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need a draft and approve system, so you wont have the techs, especially new ones, or if the tech not familiar with services included, will just send the invoice to client and then you as admin have to apologize for the mistake
i would say to find a middle point that work both ways :D

@wrongecho
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a discussion with Johnny and have raised a PR to revert that commit - #534

Please sign in to comment.