Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to remove PhantomJS dependency #221

Closed
patrickberkeley opened this issue Jun 6, 2018 · 2 comments
Closed

Plans to remove PhantomJS dependency #221

patrickberkeley opened this issue Jun 6, 2018 · 2 comments

Comments

@patrickberkeley
Copy link

This package relies on svg2png. svg2png uses PhantomJS which has been sunsetted.

Are there any plans to remove the svg2png/PhantomJS dependency from this package?

@alexander-akait
Copy link
Member

alexander-akait commented Jun 9, 2018

@patrickberkeley yes, PR welcome

@lovell
Copy link
Contributor

lovell commented Oct 5, 2018

Hello, I've had a (very) quick look at whether sharp/libvips/librsvg might be suitable to replace PhantomJS in the context of SVG rendering in this module.

At the moment the tests rely on snapshots that require pixel values to be an exact match.

Switching to a testing approach that verifies based on image similarity, with a suitable threshold, could help not only with a migration away from PhantomJS but also with a possible future move to a plugin-based approach where different renderers might be considered. Happy to help if this is something that others think is suitable.

pniederlag added a commit to pniederlag/favicons that referenced this issue Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants