-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans to remove PhantomJS dependency #221
Comments
@patrickberkeley yes, PR welcome |
Hello, I've had a (very) quick look at whether sharp/libvips/librsvg might be suitable to replace PhantomJS in the context of SVG rendering in this module. At the moment the tests rely on snapshots that require pixel values to be an exact match. Switching to a testing approach that verifies based on image similarity, with a suitable threshold, could help not only with a migration away from PhantomJS but also with a possible future move to a plugin-based approach where different renderers might be considered. Happy to help if this is something that others think is suitable. |
rebased/updated commit/patch from itgalaxy@b1f04b3
This package relies on svg2png. svg2png uses PhantomJS which has been sunsetted.
Are there any plans to remove the svg2png/PhantomJS dependency from this package?
The text was updated successfully, but these errors were encountered: