Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to Ava #206

Merged
merged 8 commits into from
Mar 30, 2018
Merged

Migrate tests to Ava #206

merged 8 commits into from
Mar 30, 2018

Conversation

brunocodutra
Copy link
Collaborator

relates to #205

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@alexander-akait
Copy link
Member

Only looks tests failed, need fix it 👍

@brunocodutra
Copy link
Collaborator Author

@evilebottnawi I'll add code coverage report with this PR before getting it merged

@alexander-akait
Copy link
Member

@brunocodutra let's always use npm@5 in tests and use npm ci

@alexander-akait
Copy link
Member

npm i -g npm@5

@brunocodutra
Copy link
Collaborator Author

@evilebottnawi should I commit package-lock.json as well then?

@alexander-akait
Copy link
Member

@brunocodutra yes, lock file always should be in repo

@brunocodutra
Copy link
Collaborator Author

@evilebottnawi for some reason npm ci doesn't fly on travis, it chokes on prepublish because appearently gulp is not installed, any idea what's going wrong?

https://travis-ci.org/evilebottnawi/favicons/jobs/360218204#L462

@alexander-akait
Copy link
Member

very strange, seems npm bug, let's install gulp manually after npm ci

@brunocodutra
Copy link
Collaborator Author

@evilebottnawi oh wait, that won't work, because prepublish runs just after npm ci, so installing it afterwards won't help.

I guess I'll have to fall back to npm install?

@alexander-akait
Copy link
Member

@brunocodutra hm, let's use npm install before we migrate from gulp, we can rewrite stream tests without gulp

@brunocodutra
Copy link
Collaborator Author

@evilebottnawi CI finally passed, could you take a look at it again?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brunocodutra brunocodutra merged commit 6c30094 into master Mar 30, 2018
@brunocodutra brunocodutra deleted the ava branch March 30, 2018 11:59
@alexander-akait alexander-akait mentioned this pull request Mar 30, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants