-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests to Ava #206
Migrate tests to Ava #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Only looks tests failed, need fix it 👍 |
@evilebottnawi I'll add code coverage report with this PR before getting it merged |
@brunocodutra let's always use |
|
@evilebottnawi should I commit |
@brunocodutra yes, lock file always should be in repo |
@evilebottnawi for some reason https://travis-ci.org/evilebottnawi/favicons/jobs/360218204#L462 |
very strange, seems npm bug, let's install gulp manually after |
@evilebottnawi oh wait, that won't work, because I guess I'll have to fall back to |
@brunocodutra hm, let's use |
@evilebottnawi CI finally passed, could you take a look at it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
relates to #205