Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format with prettier #208

Merged
merged 3 commits into from
Mar 30, 2018
Merged

Format with prettier #208

merged 3 commits into from
Mar 30, 2018

Conversation

brunocodutra
Copy link
Collaborator

No description provided.

@alexander-akait alexander-akait mentioned this pull request Mar 30, 2018
Open
8 tasks
@brunocodutra
Copy link
Collaborator Author

@evilebottnawi should appveyor/pr status be required just like travis?

alexander-akait
alexander-akait approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Let's wait when CI green and feel free to merge 👍

@alexander-akait
Copy link
Member

@brunocodutra yes

@evilebottnawi should appveyor/pr status be required just like travis?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 376

  • 244 of 298 (81.88%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 76.923%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.js 96 108 88.89%
src/helpers.js 148 190 77.89%
Totals Coverage Status
Change from base Build 374: -0.5%
Covered Lines: 246
Relevant Lines: 300
💛 - Coveralls

@brunocodutra brunocodutra merged commit 8bf9f93 into master Mar 30, 2018
@brunocodutra brunocodutra deleted the formatting branch March 30, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brunocodutra @alexander-akait @coveralls