Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a promise if callback is undefined #210

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Return a promise if callback is undefined #210

merged 1 commit into from
Mar 30, 2018

Conversation

brunocodutra
Copy link
Collaborator

@brunocodutra brunocodutra commented Mar 30, 2018 •
edited
Loading

Relates to #205

Closes #197

@alexander-akait alexander-akait mentioned this pull request Mar 30, 2018
Open
8 tasks
alexander-akait
alexander-akait approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to merge when CI will be green

@coveralls
Copy link

Pull Request Test Coverage Report for Build 383

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 76.977%
Totals Coverage Status
Change from base Build 377: 0.05%
Covered Lines: 247
Relevant Lines: 301
💛 - Coveralls

@brunocodutra brunocodutra merged commit 6759f91 into master Mar 30, 2018
@brunocodutra brunocodutra deleted the promisify branch March 30, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brunocodutra @coveralls @alexander-akait