-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Granularity in icons options #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @perrin4869
Any news on this one? Would love to see this implemented. Currently we're generating a huge amount of images of which we only need like 4.. |
This looks good to me!!!! |
@perrin4869 merge and release? |
Go ahead :) |
Thanks! |
@evilebottnawi @perrin4869 Will you also do a chore release today with these changes? :) |
@PhilippMeissner Sorry for delay, many work 😞 Done https://github.com/itgalaxy/favicons/releases/tag/v6.2.0 |
@Voltra does this also update the generated html? I don't see any change to |
@dmnsgn I must admit I was completely focused on the icon generation part and did not look that deeply into it. From what I saw this would probably mean a complete rework of the html rendering so this may be a task for a separate (but related) issue. |
@Voltra Can you send a fix? |
I'm working on it, would have been easier if tests and generation did not rely on hardcoded useless and incoherent whitespaces between HTML attributes (between 1 and 3). I should come up with a pull request pretty soon |
Add the ability to specify the exhaustive list of icons to generate per platform