Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Granularity in icons options #312

Merged
merged 4 commits into from
Jul 17, 2020
Merged

Conversation

Voltra
Copy link
Contributor

@Voltra Voltra commented Jul 8, 2020

Add the ability to specify the exhaustive list of icons to generate per platform

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhilippMeissner
Copy link

PhilippMeissner commented Jul 17, 2020

Any news on this one? Would love to see this implemented. Currently we're generating a huge amount of images of which we only need like 4..

@perrin4869
Copy link
Contributor

This looks good to me!!!!

@alexander-akait
Copy link
Member

@perrin4869 merge and release?

@perrin4869
Copy link
Contributor

Go ahead :)

@alexander-akait alexander-akait merged commit 2eccc52 into itgalaxy:master Jul 17, 2020
@alexander-akait
Copy link
Member

Thanks!

@PhilippMeissner
Copy link

@evilebottnawi @perrin4869 Will you also do a chore release today with these changes? :)

@alexander-akait
Copy link
Member

@PhilippMeissner Sorry for delay, many work 😞 Done https://github.com/itgalaxy/favicons/releases/tag/v6.2.0

@dmnsgn
Copy link
Contributor

dmnsgn commented Jul 22, 2020

@Voltra does this also update the generated html? I don't see any change to src/config/html.js.

@Voltra
Copy link
Contributor Author

Voltra commented Jul 22, 2020

@dmnsgn I must admit I was completely focused on the icon generation part and did not look that deeply into it. From what I saw this would probably mean a complete rework of the html rendering so this may be a task for a separate (but related) issue.

@alexander-akait
Copy link
Member

@Voltra Can you send a fix?

@Voltra
Copy link
Contributor Author

Voltra commented Jul 27, 2020

I'm working on it, would have been easier if tests and generation did not rely on hardcoded useless and incoherent whitespaces between HTML attributes (between 1 and 3). I should come up with a pull request pretty soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants