Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Jimp by Sharp #338

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Replace Jimp by Sharp #338

merged 1 commit into from
Oct 19, 2021

Conversation

andy128k
Copy link
Collaborator

Closes #329

@alexander-akait
Copy link
Member

@andy128k Big thanks, maybe you can help me with github actions, we need migrate on them and test this on linux/windows/macos (just don't have enough time), thanks

@andy128k
Copy link
Collaborator Author

@alexander-akait see #339 😏

@alexander-akait
Copy link
Member

@andy128k let's fix tests on macos, looks like small difference in images on macos

@andy128k
Copy link
Collaborator Author

@alexander-akait see #341

@alexander-akait
Copy link
Member

@andy128k big thanks again, let's rebase

@andy128k
Copy link
Collaborator Author

@alexander-akait now it works

@alexander-akait
Copy link
Member

@andy128k Should we solve compatibility with Node.js v16 before new release (I think yes 😄 )?

@alexander-akait alexander-akait merged commit e0240c7 into itgalaxy:master Oct 19, 2021
@andy128k andy128k deleted the replace-jimp-by-sharp branch October 19, 2021 11:54
@andy128k
Copy link
Collaborator Author

@alexander-akait This may be tricky.

ava does not support asynchronous snapshot matchers. It may require to rewrite tests or even migrate to another testing library (jest maybe?).

@alexander-akait
Copy link
Member

Yes, jest sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace JIMP with Sharp?
2 participants