Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transpile co CJS to keep backward compatibility #355

Closed
wants to merge 1 commit into from
Closed

Transpile co CJS to keep backward compatibility #355

wants to merge 1 commit into from

Conversation

andy128k
Copy link
Collaborator

@andy128k andy128k commented Nov 1, 2021

No description provided.

alexander-akait
alexander-akait reviewed Nov 1, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ESM only is better, time to drop commonjs

@andy128k
Copy link
Collaborator Author

andy128k commented Nov 1, 2021

Generally, I agree that ESM is the way to go. What disturbs me is that it is a breaking change and things like favicons-webpack-plugin will require switch to ESM too.

@alexander-akait
Copy link
Member

They can use import().then() to load ESM in CommonJS

@andy128k andy128k mentioned this pull request Nov 1, 2021
Merged
@andy128k andy128k closed this in #356 Nov 1, 2021
@andy128k andy128k deleted the backward-compat-cjs branch November 1, 2021 14:46
@andy128k andy128k mentioned this pull request Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andy128k @alexander-akait