-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add webmanifest's shortcuts support #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this feature should respect option output: { images: false }
.
Thank you for the fast review, I've addressed all your comments and fixed another typo from me, which broke Also rebased on the current master to resolve the small conflict with 9632b9d.
I'll look at it tomorrow, but if I read the code correctly then the maskable icons doesn't respect it either? |
It looks like both maskable and shortcuts respect |
@chrmoritz Thanks! |
This PR adds support for webmanifest's shortcuts. For more information see:
https://developer.mozilla.org/en-US/docs/Web/Manifest/shortcuts
https://web.dev/app-shortcuts/
https://w3c.github.io/manifest/#shortcuts-member
Example usage:
See also the added test and readme changes for usage of this new feature.