Skip to content

Commit

Permalink
Remove old onBackground attribute from sidenav storybook story (#671)
Browse files Browse the repository at this point in the history
* fix(sidenav): remove onBackground attribute

When merging the latest develop into this release branch the sidenav
component ended up with both the old onBackground and new isOnBackground
versions of the attribute in its storybook story. This removes the old
version so it is correct.

* chore: add changeset
  • Loading branch information
brentswisher committed Jan 22, 2024
1 parent 13460c1 commit 145da90
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/eleven-spoons-shop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': patch
---

Remove deprecated onBackground attribute from sidenav storybook story
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ export const Base = {
variant="subtle"
isOnBackground
a11yLabel="search"
onBackground
></PharosButton>
</PharosInputGroup>
<PharosSidenavSection showDivider>
Expand Down

0 comments on commit 145da90

Please sign in to comment.