Update deprecated a11y attributes in button component #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pressed attribute is deprecated in favor of a11y-pressed. This updates the toggle button group to use the new attribute and stop console logging deprecation warnings when it is used.
Recently the label attribute was deprecated in favor of a11y-label. This updtes all the button uses internal to the library to use the new attribute. This prevents confusing warnings in the console for the end users.
brentswisher
requested review from
sirrah-tam,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
🦋 Changeset detectedLatest commit: bd392a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
satya-achanta-venkata
approved these changes
Jan 18, 2024
mtorres3
approved these changes
Jan 18, 2024
sirrah-tam
approved these changes
Jan 18, 2024
Merged
daneah
added a commit
that referenced
this pull request
Mar 8, 2024
* develop: (77 commits) chore(deps): update GitHub Actions and Node versions (#704) fix(site): use Pharos v14 properties (#703) fix(storybook): update Babel configuration (#702) fix(infra): use Node 18 in .nvmrc (#701) fix(infra): update dependencies fix(infra): allow mutable Yarn lockfile during release for workspaces versions Version Packages (#700) Release/14.0.0 (#697) chore(deps): upgrade to Yarn 4 (#694) chore(deps): bump es5-ext from 0.10.62 to 0.10.64 (#692) fix(icon): add media query style for WHCM (#689) chore(deps): bump ip from 1.1.8 to 1.1.9 (#687) chore: version packages (#685) Icon: Add "add to folder" icon (#678) Fix the all-contributors badge (#680) Update link, dropdown-menu-nav, and popover to use a11y-label (#675) DropdownMenuNav: Add pharos-elevation-level-3 token (#670) chore(deps-dev): bump vite from 4.3.9 to 4.5.2 (#672) chore: version packages (#667) Update deprecated a11y attributes in button component (#666) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
While working on #660 I noticed that there were similar deprecation warnings being thrown for attributes recently updated in the button component not being used internally. This causes confusing console logs which are out of the control of the library's consumers to be shown when some components were rendered.
How does this change work?
Updates all internal instances of the button component to use the
a11y-pressedanda11y-labelattributes.