Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/14.0.0 #697

Merged
merged 38 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
eaa514f
Infra: Bump TypeScript, add main exports (#472)
Jan 20, 2023
1913341
Tabs: move selected state management to pharos-tabs (#468)
Jan 23, 2023
b9eedf6
Toast: Update Toaster to use internally consistent scoping (#475)
daneah Jan 25, 2023
041f176
Site: fix site build (#481)
Jan 25, 2023
55c3bda
chore: resolve merge conflicts
mtorres3 Aug 4, 2023
90872de
Merge branch 'develop' into release/13.0.0
daneah Aug 20, 2023
35dda81
fix: update incorrect imports
daneah Aug 20, 2023
73449c2
chore: update storybook deps
daneah Aug 20, 2023
3b0d691
fix: use public registry
daneah Aug 20, 2023
eb228d5
Footer: Remove google translate (#586)
daneah Aug 20, 2023
6a04d08
Merge branch 'develop' into release/13.0.0
Aug 24, 2023
55bb640
Merge branch 'develop' into release/13.0.0
daneah Sep 15, 2023
d026826
Remove `paint` value from contain properties (#614)
daneah Sep 19, 2023
75c2382
Merge branch 'develop' into release/13.0.0
satya-achanta-venkata Sep 29, 2023
52006f3
Global: update onBackground to isOnBackground (#578)
mtorres3 Nov 29, 2023
ace35cf
Sidenav: remove sidenav button (#478)
Nov 29, 2023
a7279ce
Merge branch 'develop' into release/14.0.0
daneah Dec 19, 2023
f8342cc
a11y revamp: Pharos Buttons (#594)
sirrah-tam Jan 4, 2024
e89bcaf
Loading Spinner, Sidenav, Docs: use is-on-background correctly (#657)
daneah Jan 4, 2024
fa51148
chore(deps): bump msgpackr from 1.7.2 to 1.10.1 (#654)
dependabot[bot] Jan 2, 2024
899fb1e
Fix broken whitespace in Icon documentation (#616)
david-corneail Jan 4, 2024
01abaf6
fix(chromatic): reintroduce build-storybook script (#656)
daneah Jan 4, 2024
13460c1
Merge branch 'develop' into release/14.0.0
brentswisher Jan 19, 2024
145da90
Remove old onBackground attribute from sidenav storybook story (#671)
brentswisher Jan 22, 2024
536a598
Update link, dropdown-menu-nav, and popover to use a11y-label - Break…
sirrah-tam Jan 23, 2024
8f8c2bb
fix(link): update SB to pass in a11yLabel values (#677)
sirrah-tam Jan 23, 2024
60f2a09
DropdownMenu: add nav category to replace links (#479)
Jan 23, 2024
a1ade7a
Require icon accessibility attributes (#679)
brentswisher Feb 8, 2024
551c5e9
Combobox: Add default elevation (#683)
brentswisher Feb 13, 2024
67684b7
Modal: Add default elevation (#681)
brentswisher Feb 13, 2024
3992876
feat(popover): add elevation token (#682)
brentswisher Feb 13, 2024
c2a2248
Dropdown Menu: Add default elevation (#684)
brentswisher Feb 13, 2024
fda9018
Tabs: Remove overflow-y from pharos-tabs' tab__panels class (#690)
ymouzakis Feb 27, 2024
8ca6aeb
Add ability to use a11y-disabled and maintain default disabled stylin…
sirrah-tam Mar 4, 2024
bbdb966
Merge branch 'develop' into release/14.0.0
daneah Mar 7, 2024
df71253
Update Storybook stories with new sidenav display logic (#696)
brentswisher Mar 7, 2024
13ed2f3
hotfix: update sidenav button to use a11yLabel
brentswisher Mar 7, 2024
38322bc
Require an accessible label be present for icon-only buttons (#699)
brentswisher Mar 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-weeks-own.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': minor
---

Add elevation style to modal component
5 changes: 5 additions & 0 deletions .changeset/chilled-lizards-ring.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': patch
---

Add ability to use a11y-disabled and maintain default disabled styling
5 changes: 5 additions & 0 deletions .changeset/cold-jeans-fail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': major
---

Update Toaster to use internally consistent component scoping
6 changes: 6 additions & 0 deletions .changeset/eight-dots-cry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@ithaka/pharos': major
'@ithaka/pharos-site': major
---

Use is-on-background in place of on-background
5 changes: 5 additions & 0 deletions .changeset/eleven-spoons-shop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': patch
---

Remove deprecated onBackground attribute from sidenav storybook story
5 changes: 5 additions & 0 deletions .changeset/five-moles-add.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': major
---

Remove `paint` value of contain property globally
5 changes: 5 additions & 0 deletions .changeset/flat-clocks-brush.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': minor
---

Add default elevation and remove border from combobox component
5 changes: 5 additions & 0 deletions .changeset/gorgeous-months-vanish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': major
---

remove sidenav button, add consumer controls
5 changes: 5 additions & 0 deletions .changeset/kind-cows-mix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': patch
---

Update storybook stories to work with new sidenav display logic
7 changes: 7 additions & 0 deletions .changeset/light-paws-listen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@ithaka/pharos': patch
'@ithaka/pharos-site': patch
'@ithaka/pharos-cli': patch
---

Update onBackground prop to isOnBackground
5 changes: 5 additions & 0 deletions .changeset/long-hotels-allow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': major
---

Update all use of label attribute to a11y-label
7 changes: 7 additions & 0 deletions .changeset/mighty-planes-poke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@ithaka/pharos': major
---

Add additional ARIA attributes for Pharos button
and use a new naming convention for these specific
pharos attributes.
5 changes: 5 additions & 0 deletions .changeset/perfect-cycles-drum.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': major
---

pharos-tab `selected` has been deprecated, see new property for pharos-tabs `selected-tab`
5 changes: 5 additions & 0 deletions .changeset/pink-ties-tell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': minor
---

Update popover component elevation to use design token
5 changes: 5 additions & 0 deletions .changeset/quiet-garlics-compete.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': minor
---

Add default elevation and remove border from dropdown-menu
5 changes: 5 additions & 0 deletions .changeset/sharp-kings-move.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': patch
---

Updates the Link to use a11yLabel values within Storybook
6 changes: 6 additions & 0 deletions .changeset/sweet-singers-arrive.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@ithaka/pharos': major
'@ithaka/pharos-site': major
---

individual file exports are no longer supported, import files based on the exports defined in the package.json
6 changes: 6 additions & 0 deletions .changeset/thick-planes-wink.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@ithaka/pharos': major
'@ithaka/pharos-site': major
---

Remove deprecated Google Translate widget
5 changes: 5 additions & 0 deletions .changeset/thirty-carrots-suffer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': patch
---

Require all icons to have a label or be explicitly hidden
5 changes: 5 additions & 0 deletions .changeset/weak-berries-hunt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': major
---

Remove overflow-y from pharos-tabs tab panels
4 changes: 2 additions & 2 deletions .storybook/initComponents.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
PharosDropdownMenuItem,
PharosDropdownMenuNav,
PharosDropdownMenuNavLink,
PharosDropdownMenuNavCategory,
PharosFooter,
PharosHeader,
PharosHeading,
Expand All @@ -30,7 +31,6 @@ import {
PharosSelect,
PharosSheet,
PharosSidenav,
PharosSidenavButton,
PharosSidenavLink,
PharosSidenavMenu,
PharosSidenavSection,
Expand Down Expand Up @@ -61,6 +61,7 @@ registerComponents('storybook', [
PharosDropdownMenuItem,
PharosDropdownMenuNav,
PharosDropdownMenuNavLink,
PharosDropdownMenuNavCategory,
PharosFooter,
PharosHeader,
PharosHeading,
Expand All @@ -80,7 +81,6 @@ registerComponents('storybook', [
PharosSelect,
PharosSheet,
PharosSidenav,
PharosSidenavButton,
PharosSidenavLink,
PharosSidenavMenu,
PharosSidenavSection,
Expand Down
Binary file modified .yarn/install-state.gz
Binary file not shown.
brentswisher marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,15 @@ Create an (enforced) convention of property names that, when supplied at the cus
When a custom element has a a11y-\* attribute, that attribute gets passed down to the appropriate (as decided on a per-component basis) underlying native element.

```html
<pharos-button a11y-aria-describedby="the-tooltip">
Click me
</pharos-button>
<pharos-button a11y-aria-describedby="the-tooltip"> Click me </pharos-button>

<pharos-tooltip id="the-tooltip">
I am a tooltip
</pharos-tooltip>
<pharos-tooltip id="the-tooltip"> I am a tooltip </pharos-tooltip>
```

The button’s shadow DOM would then look like:

```html
<button aria-describedby="the-tooltip">
Click me
</button>
<button aria-describedby="the-tooltip">Click me</button>
```

Shorter attribute names could have been used for brevity, but we should in general avoid possible conflicts with valid HTML5 attribute names.
Expand Down
20 changes: 10 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,16 @@
"@commitlint/config-conventional": "^15.0.0",
"@emotion/babel-plugin": "^11.9.2",
"@size-limit/preset-small-lib": "^7.0.4",
"@storybook/addon-a11y": "^7.2.1",
"@storybook/addon-essentials": "^7.2.1",
"@storybook/addon-links": "^7.2.1",
"@storybook/addon-a11y": "^7.3.2",
"@storybook/addon-essentials": "^7.3.2",
"@storybook/addon-links": "^7.3.2",
"@storybook/addon-styling": "^1.3.5",
"@storybook/blocks": "^7.2.1",
"@storybook/manager-api": "^7.2.1",
"@storybook/react-vite": "^7.2.1",
"@storybook/theming": "^7.2.1",
"@storybook/web-components": "^7.2.1",
"@storybook/web-components-vite": "^7.2.1",
"@storybook/blocks": "^7.3.2",
"@storybook/manager-api": "^7.3.2",
"@storybook/react-vite": "^7.3.2",
"@storybook/theming": "^7.3.2",
"@storybook/web-components": "^7.3.2",
"@storybook/web-components-vite": "^7.3.2",
"@types/uuid": "^9.0.0",
"@typescript-eslint/eslint-plugin": "^6.9.0",
"@typescript-eslint/parser": "^6.9.0",
Expand Down Expand Up @@ -108,7 +108,7 @@
"react-dom": "^17.0.0",
"sass": "^1.63.6",
"size-limit": "^7.0.4",
"storybook": "^7.2.1",
"storybook": "^7.3.2",
"stylelint": "^15.10.1",
"stylelint-config-prettier": "^9.0.5",
"stylelint-config-standard-scss": "^10.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/pharos-site/initComponents.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ if (typeof window !== `undefined`) {
pharos.PharosDropdownMenuItem,
pharos.PharosDropdownMenuNav,
pharos.PharosDropdownMenuNavLink,
pharos.PharosDropdownMenuNavCategory,
pharos.PharosFooter,
pharos.PharosHeader,
pharos.PharosHeading,
Expand All @@ -33,7 +34,6 @@ if (typeof window !== `undefined`) {
pharos.PharosRadioGroup,
pharos.PharosSelect,
pharos.PharosSidenav,
pharos.PharosSidenavButton,
pharos.PharosSidenavLink,
pharos.PharosSidenavMenu,
pharos.PharosSidenavSection,
Expand Down
3 changes: 1 addition & 2 deletions packages/pharos-site/src/components/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ const Layout: FC<LayoutProps> = ({ children, location, fill }) => {
const [MainContent, setMainContent] = useState<ReactElement | null>(null);

useEffect(() => {
const { PharosSidenavButton, PharosLink, PharosLayout } = Pharos;
const { PharosLink, PharosLayout } = Pharos;

const body = (
<main className={main}>
<div className={topBar}>
<PharosSidenavButton onBackground />
<PharosLink id="skip-link" skip href="#sidenav-skip-link" onBackground>
Skip to main navigation
</PharosLink>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { FC, CSSProperties } from 'react';
import { colorBox } from './ColorCombos.module.css';
import tokens from '@ithaka/pharos/lib/styles/tokens.js';
import tokens from '@ithaka/pharos/lib/styles/tokens';
import CrossOut from '../CrossOut';
import { toTitleCase } from '../../../utils/textConvert';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useEffect, useState } from 'react';
import type { FC, ReactElement } from 'react';
import tokens from '@ithaka/pharos/lib/styles/tokens.js';
import tokens from '@ithaka/pharos/lib/styles/tokens';
import { colorGradient, gradientLabel, gradientContainer } from './ColorGradients.module.css';

interface Gradient {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useEffect, useState } from 'react';
import type { FC, ReactElement, CSSProperties } from 'react';
import tokens from '@ithaka/pharos/lib/styles/tokens.js';
import tokens from '@ithaka/pharos/lib/styles/tokens';
import {
figure,
colorSwatch,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { FC, CSSProperties } from 'react';
import { container, container_text } from './ColorTextSquares.module.css';
import tokens from '@ithaka/pharos/lib/styles/tokens.js';
import tokens from '@ithaka/pharos/lib/styles/tokens';
import { toTitleCase } from '../../../utils/textConvert';

interface ColorTextSquaresProps {
Expand Down
4 changes: 2 additions & 2 deletions packages/pharos-site/static/guidelines/button.docs.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,8 @@ import ellipsesExample from '@images/components/button/buttons_ellipses-example.
<PageSection title="Buttons on dark background" subSectionLevel={1}>
<p>
When a button is used on a darker background (e.g., black or marble-gray-20), use the
on-background attribute. The four variants described above can all be used on dark backgrounds
and follow the same guidelines.
is-on-background attribute. The four variants described above can all be used on dark
backgrounds and follow the same guidelines.
</p>
<div
style={{
Expand Down
1 change: 0 additions & 1 deletion packages/pharos-site/static/guidelines/footer.docs.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,6 @@ import BestPractices from '@components/statics/BestPractices.tsx';
</PharosLink>
</li>
</ul>
<div slot="google-widget" id="google_translate_element" aria-hidden="true"></div>
</PharosFooter>
```

Expand Down
17 changes: 16 additions & 1 deletion packages/pharos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,5 +90,20 @@
"ts-lit-plugin": "^1.2.1",
"typescript": "^5.2.2"
},
"customElements": "custom-elements.json"
"customElements": "custom-elements.json",
"exports": {
".": "./lib/index.js",
"./lib": "./lib/index.js",
"./lib/index": "./lib/index.js",
"./lib/react-components": "./lib/react-components/index.js",
"./lib/styles/*": "./lib/styles/*.js",
"./lib/styles/*.css": "./lib/styles/*.css",
"./lib/styles/*.scss": "./lib/styles/*.scss",
"./lib/styles/pharos": "./lib/styles/pharos.scss",
"./lib/utils/scss/mixins": "./lib/utils/scss/_mixins.scss",
"./lib/utils/registerComponents": "./lib/utils/registerComponents.js",
"./lib/utils/PharosContext": "./lib/utils/PharosContext.js",
"./package.json": "./package.json",
"./custom-elements.json": "./custom-elements.json"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ describe('pharos-alert', () => {
class="alert__icon"
data-pharos-component="PharosIcon"
a11y-hidden="true"
description=""
name="info-inverse"
>
</pharos-icon>
Expand Down
2 changes: 1 addition & 1 deletion packages/pharos/src/components/base/form-element.scss
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ $groupable-elements: radio-element checkbox-element;
@include mixins.hidden;
}

:host([on-background]) label[for='#{$element}'] {
:host([is-on-background]) label[for='#{$element}'] {
color: var(--pharos-color-text-white);
}

Expand Down
Loading
Loading