Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra): ensure JSDOM patch is exported #714

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

daneah
Copy link
Member

@daneah daneah commented Mar 12, 2024

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?

During #212 we restricted what is exported for available use to consumers, which accidentally stopped including the patches/jsdom.js file.

How does this change work?

Allow anything from patches/ to be included (currently just the jsdom.js file)

@daneah daneah requested a review from a team as a code owner March 12, 2024 18:38
@daneah daneah requested review from brentswisher, sirrah-tam and mtorres3 and removed request for a team March 12, 2024 18:38
Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: 3be4090

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 12, 2024

size-limit report 📦

Path Size
packages/pharos/lib/index.js 54.53 KB (0%)

@daneah daneah merged commit ca0396a into develop Mar 12, 2024
3 checks passed
@daneah daneah deleted the fix/ensure-jsdom-patch-is-exported branch March 12, 2024 18:55
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants