Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coach Mark: Emit event when user hits the close button #733

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

michael-iden
Copy link
Contributor

@michael-iden michael-iden commented Mar 21, 2024

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Resolves #732 to allow the consuming app to know about coach mark dismissal

How does this change work?
Emit pharos-coach-mark-closed

Additional context
N/A

Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: 506f029

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michael-iden michael-iden changed the title feat(coach-mark): emit event when user hits the close button Coach Mark: emit event when user hits the close button Mar 21, 2024
Copy link
Contributor

github-actions bot commented Mar 21, 2024

size-limit report 📦

Path Size
packages/pharos/lib/index.js 64.42 KB (+0.12% 🔺)

@michael-iden michael-iden changed the title Coach Mark: emit event when user hits the close button Coach Mark: Emit event when user hits the close button Mar 21, 2024
@michael-iden michael-iden merged commit 20a8596 into develop Mar 21, 2024
11 checks passed
@michael-iden michael-iden deleted the feature/coach-mark-closed-event branch March 21, 2024 18:56
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coachmark: Emit event when dismissed
3 participants