Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyFile #127

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Add copyFile #127

merged 1 commit into from
Jul 18, 2016

Conversation

superandrew213
Copy link
Contributor

No description provided.

@johanneslumpe
Copy link
Collaborator

johanneslumpe commented Jul 11, 2016

Thanks! Sorry, was on vacation :) Why are you printing the stack trace before sending back the error on Android? Is that an Android best practice? Just wondering if there are any downsides to it in terms of performance (if it is not required)

Looks good to me in general though!

@superandrew213
Copy link
Contributor Author

@johanneslumpe no problem :)

I just followed the same structure you had for the other methods.

@johanneslumpe
Copy link
Collaborator

@superandrew213 Ah ok - I didn't write any of the Android stuff. @cjdell can you shed some light on this?

@superandrew213
Copy link
Contributor Author

@johanneslumpe all other methods follow this structure. Maybe we can merge this PR then later evaluate performance issues since we have to change all other methods. What do you think?

@johanneslumpe
Copy link
Collaborator

@superandrew213 sure, fine with me!

@johanneslumpe johanneslumpe merged commit 6d12970 into itinance:master Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants