Route agency_id is optional

[rorlic]

Class GTFS.Entities.Route (incorrectly) defines AgencyId as [Required] but the GTFS reference claims it is optional. In addition, the GTFsFeedValidation class checks the existence of the agency_id value in the list of known agencies. Obviously, if AgencyId is null, the check will fail.

            // check routes.
            var routeIds = new HashSet<string>();
            foreach(var route in feed.Routes)
            {
                if (routeIds.Contains(route.Id))
                { // oeps, duplicate id.
                    messages = string.Format("Duplicate route id found: {0}", route.Id);
                    return false;
                }
                routeIds.Add(route.Id);
                if (!agencyIds.Contains(route.AgencyId))
                {// oeps, unknown id.
                    messages = string.Format("Unknown agency found in route {0}: {1}", route.Id, route.AgencyId);
                    return false;
                }
            }

[rorlic]

I have forked to rorlic/GTFS and fixed it.

[scottharwell]

@rorlic Have you submitted your fix as a pull request to this repo? It would be nice to merge into the main repo so that NuGet subscribers can take advantage of the update automatically. I am currently experiencing a similar issue, where a feed omits this field and the GTFS library throws an exception rather than ignoring an optional field.

[xivk]

@scottharwell The fixes are already merged. The publish failed because the version # was left unchanged. There should now be a new version on nuget.

[andyf101]

GTFS.Entities.Route still has a Required attribute on AgencyId in this main repo as well as the fork. The spec shows that agency_id is optional for Route and also optional for Agency.

[xivk]

Removed the required attribute. This doesn't change anything, the attributes should be removed altogether in the future.