Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings containing quotes are not properly quoted by the GTFSWriter #77

Closed
thzinc opened this issue Apr 22, 2022 · 1 comment · Fixed by #78
Closed

Strings containing quotes are not properly quoted by the GTFSWriter #77

thzinc opened this issue Apr 22, 2022 · 1 comment · Fixed by #78

Comments

@thzinc
Copy link
Contributor

thzinc commented Apr 22, 2022

Any string value that is written using the GTFSWriter.WriteFieldString(string, string, string) signature where the value contains a " but no , is not properly escaped in the result.

Example call:

this.WriteFieldString("trips", "trip_headsign", "\"this is a string containing a quoted value\"");

Expected:

"""this is a string containing a quoted value"""

Actual:

""this is a string containing a quoted value""
thzinc added a commit to syncromatics/GTFS that referenced this issue Apr 22, 2022
@thzinc
Copy link
Contributor Author

thzinc commented Apr 22, 2022

Also found that reading GTFS files with strings containing escaped quotes failed too

@xivk xivk closed this as completed in #78 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant