[bug fix] Use PreparedStatement objects under thread-safe conditions

itinycheng · Aug 16, 2021 · 3451515 · 3451515
1 parent 0e5d3f4
commit 3451515
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...java/org/apache/flink/connector/clickhouse/internal/executor/ClickHouseBatchExecutor.java b/...java/org/apache/flink/connector/clickhouse/internal/executor/ClickHouseBatchExecutor.java
@@ -68,12 +68,12 @@ public synchronized void addToBatch(RowData record) throws SQLException {
     }
 
     @Override
-    public void executeBatch() throws SQLException {
+    public synchronized void executeBatch() throws SQLException {
         statement.executeBatch();
     }
 
     @Override
-    public void closeStatement() throws SQLException {
+    public synchronized void closeStatement() throws SQLException {
         if (statement != null) {
             statement.close();
             statement = null;

diff --git a/...ava/org/apache/flink/connector/clickhouse/internal/executor/ClickHouseUpsertExecutor.java b/...ava/org/apache/flink/connector/clickhouse/internal/executor/ClickHouseUpsertExecutor.java
@@ -97,7 +97,7 @@ public synchronized void addToBatch(RowData record) throws SQLException {
     }
 
     @Override
-    public void executeBatch() throws SQLException {
+    public synchronized void executeBatch() throws SQLException {
         for (ClickHousePreparedStatement clickHousePreparedStatement :
                 Arrays.asList(insertStmt, updateStmt, deleteStmt)) {
             if (clickHousePreparedStatement != null) {
@@ -107,7 +107,7 @@ public void executeBatch() throws SQLException {
     }
 
     @Override
-    public void closeStatement() throws SQLException {
+    public synchronized void closeStatement() throws SQLException {
         for (ClickHousePreparedStatement clickHousePreparedStatement :
                 Arrays.asList(insertStmt, updateStmt, deleteStmt)) {
             if (clickHousePreparedStatement != null) {