Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance sent out in svarteliste-mails is wrong #73

Open
BorBorBor opened this issue Nov 16, 2021 · 1 comment
Open

Balance sent out in svarteliste-mails is wrong #73

BorBorBor opened this issue Nov 16, 2021 · 1 comment

Comments

@BorBorBor
Copy link
Contributor

The feature added in commit 483f82e works as programmed but not as intended; users get the svartelistet-email immediately when they pass the block limit. In practice the administrator will add more than one list after BSF so the balance will usually decrease further after this email is sent. I.e. I now got an email saying "your balance is –n" while in reality it was closer to –10n.

Suggested fix: adding a delay of (say) an hour between triggering the mail and actually sending the mail would solve this. But currently the feature adds more confusion than it resolves.

@olepbr
Copy link
Contributor

olepbr commented Nov 22, 2021

You're quite right, Bor, thanks for pointing this out! I'll have a go at it once exams are out of the way. I might also add a line to the email clarifying that the balance might've decreased further by the time the email is read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants