add custom template re-generation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds `-v` / `--version` command line option
---
* Custom templates can become stale as standard templates change
over time.
* Adds `-r` / `--regenerate` option to rebuild custom templates by:
- adding a json footer comment to all newly created custom templates
with details of the source / destination templates + cloudinit &
override used to create the custom template
- firstly regenerates all `base` templates that override `standard`
templates
- afterwards regenerates all `custom` templates that override `base`
templates
* Existing custom templates will need to be recreated (so a json footer
is written to the template) - to make use of this new functionality to
keep custom templates up to date
---
TODO: incorporate this new functionality into the template update process:
- update `base` templates when the `standard` template it is
based on changes
- update `custom` templates that override the updated `base`
template
itoffshore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-v/--versioncommand line optionCustom templates can become stale as standard templates change over time.
Adds
-r/--regenerateoption to rebuild custom templates by:jsonfooter comment to all newly createdcustomtemplates with details of the source / destination templates + cloudinit & override used to create thecustomtemplatebasetemplates that overridestandardtemplatescustomtemplates that overridebasetemplatesExisting
customtemplates will need to be recreated (so a json footer is written to the template) - to make use of this new functionality to keep custom templates up to dateTODO: incorporate this new functionality into the template update process:
basetemplates when thestandardtemplate it is based on changescustomtemplates that override the updatedbasetemplate