Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] allow install several themes at once #266

Merged
merged 4 commits into from Jan 11, 2018

Conversation

yelizariev
Copy link
Collaborator

[ADD] views to create website.theme on flight

DEV NOTE: this commit cannot be backported to 10.0, because it doesn't have
exclusive fields at module category and constraint is hardcoded for Themes

Ivan Yelizariev added 4 commits January 9, 2018 21:24
[ADD] views to create website.theme on flight

DEV NOTE: this commit cannot be backported to 10.0, because it doesn't have
exclusive fields at module category and constraint is hardcoded for Themes
because record "Multiwebsite Demo Theme" doesn't have that value.

So, do it via xml instead
Copy link

@ilmir-k ilmir-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilmir-k ilmir-k merged commit e3c9e36 into itpp-labs:11.0 Jan 11, 2018
@yelizariev
Copy link
Collaborator Author

@ilmir-k you lost important notes after squashing:

[ADD] views to create website.theme on flight
DEV NOTE: this commit cannot be backported to 10.0, because it doesn't have
exclusive fields at module category and constraint is hardcoded for Themes

Also, no need for version tag for [FIX] commits. It will useless in next odoo version and It will force us to change commit message when cherry-pick it to backport

@Railia read this too

yelizariev pushed a commit to yelizariev/website-addons that referenced this pull request Jan 24, 2018
yelizariev pushed a commit that referenced this pull request Jan 25, 2018
yelizariev pushed a commit to yelizariev/website-addons that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants