fixing UI bug with media output types

its-a-feature · Feb 15, 2024 · fd71b1c · fd71b1c
1 parent c9c2aac
commit fd71b1c
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 12 deletions.
diff --git a/MythicReactUI/CHANGELOG.MD b/MythicReactUI/CHANGELOG.MD
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.69] - 2024-02-15
+
+### Changed
+
+- Fixed an issue with displaying Media output types that would crash the screen due to a missing property
+
 ## [0.1.68] - 2024-02-14
 
 ### Changed

diff --git a/MythicReactUI/src/components/pages/Callbacks/ResponseDisplayMedia.js b/MythicReactUI/src/components/pages/Callbacks/ResponseDisplayMedia.js
@@ -24,8 +24,8 @@ import 'ace-builds/src-noconflict/theme-xcode';
 import {MythicStyledTooltip} from "../../MythicComponents/MythicStyledTooltip";
 
 
-export const ResponseDisplayMedia = ({media, expand}) =>{
-     return <DisplayMedia agent_file_id={media?.agent_file_id || ""} filename={media?.filename || undefined} expand={expand} />
+export const ResponseDisplayMedia = ({media, expand, task}) =>{
+     return <DisplayMedia agent_file_id={media?.agent_file_id || ""} task={task} filename={media?.filename || undefined} expand={expand} />
 }
 const textExtensionTypes = ["txt", "ps1", "php", "json", "yml", "yaml", "config", "cfg", "go",
     "html", "xml", "js", "java", "conf", "cs", "rb", "toml"];
@@ -76,7 +76,7 @@ export const DisplayMedia = ({agent_file_id, filename, expand, task}) => {
     }, [agent_file_id, filename]);
     const scrollContent = (node, isAppearing) => {
         // only auto-scroll if you issued the task
-        document.getElementById(`scrolltotaskbottom${task.id}`)?.scrollIntoView({
+        document.getElementById(`scrolltotaskbottom${task?.id}`)?.scrollIntoView({
             //behavior: "smooth",
             block: "end",
             inline: "nearest"

diff --git a/MythicReactUI/src/index.js b/MythicReactUI/src/index.js
@@ -15,7 +15,7 @@ import jwt_decode from 'jwt-decode';
 import {meState} from './cache';
 
 export const mythicVersion = "3.2.18-rc4";
-export const mythicUIVersion = "0.1.68";
+export const mythicUIVersion = "0.1.69";
 
 let fetchingNewToken = false;
 

diff --git a/mythic-react-docker/mythic/public/asset-manifest.json b/mythic-react-docker/mythic/public/asset-manifest.json
@@ -1,15 +1,15 @@
 {
   "files": {
     "main.css": "/new/static/css/main.00d51b79.css",
-    "main.js": "/new/static/js/main.db4b1fd5.js",
+    "main.js": "/new/static/js/main.6b13b652.js",
     "static/media/mythic@2x.png": "/new/static/media/mythic@2x.7c5b62b471ac779fd706.png",
     "static/media/mythic_red_small.svg": "/new/static/media/mythic_red_small.793b41cc7135cdede246661ec232976b.svg",
     "index.html": "/new/index.html",
     "main.00d51b79.css.map": "/new/static/css/main.00d51b79.css.map",
-    "main.db4b1fd5.js.map": "/new/static/js/main.db4b1fd5.js.map"
+    "main.6b13b652.js.map": "/new/static/js/main.6b13b652.js.map"
   },
   "entrypoints": [
     "static/css/main.00d51b79.css",
-    "static/js/main.db4b1fd5.js"
+    "static/js/main.6b13b652.js"
   ]
 }
diff --git a/mythic-react-docker/mythic/public/index.html b/mythic-react-docker/mythic/public/index.html
@@ -1 +1 @@
-<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/new/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><link rel="apple-touch-icon" href="/new/logo192.png"/><link rel="manifest" href="/new/manifest.json"/><title>Mythic</title><script defer="defer" src="/new/static/js/main.db4b1fd5.js"></script><link href="/new/static/css/main.00d51b79.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
+<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/new/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><link rel="apple-touch-icon" href="/new/logo192.png"/><link rel="manifest" href="/new/manifest.json"/><title>Mythic</title><script defer="defer" src="/new/static/js/main.6b13b652.js"></script><link href="/new/static/css/main.00d51b79.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
diff --git a/.../mythic/public/static/js/main.db4b1fd5.js → .../mythic/public/static/js/main.6b13b652.js b/.../mythic/public/static/js/main.db4b1fd5.js → .../mythic/public/static/js/main.6b13b652.js
diff --git a/...ic/static/js/main.db4b1fd5.js.LICENSE.txt → ...ic/static/js/main.6b13b652.js.LICENSE.txt b/...ic/static/js/main.db4b1fd5.js.LICENSE.txt → ...ic/static/js/main.6b13b652.js.LICENSE.txt
diff --git a/...hic/public/static/js/main.db4b1fd5.js.map → ...hic/public/static/js/main.6b13b652.js.map b/...hic/public/static/js/main.db4b1fd5.js.map → ...hic/public/static/js/main.6b13b652.js.map