Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ホーム画面のデザインを適用した #38

Merged
merged 1 commit into from Jul 6, 2021
Merged

Conversation

sizuhiko
Copy link
Contributor

@sizuhiko sizuhiko commented Jul 2, 2021

#19

やったこと

  • トップ画面のデザイン
  • チャンネル作成完了画面のデザイン
  • prettfy(トップ以外も変更になっています

やってないこと

  • エントランス画面(別のPRで対応します

@sizuhiko sizuhiko self-assigned this Jul 2, 2021
@sizuhiko
Copy link
Contributor Author

sizuhiko commented Jul 5, 2021

スクショはidobataに貼ったので、そちらを参照ください

Copy link
Contributor

@minakamoto minakamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉


let channelName: string | undefined;
let controllerUrl: string | undefined;
let speakerUrl: string | undefined;

type Params = { channelSlug: string, channelName: string };
type Params = { channelSlug: string; channelName: string };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@tastyHama tastyHama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sizuhiko sizuhiko merged commit 3ec940e into main Jul 6, 2021
@sizuhiko sizuhiko deleted the design-toppage branch July 6, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants