MESH-000 Add check for selector existence for Rollouts/Deployments (i…

…stio-ecosystem#98)

admiral/pkg/clusters/handler.go

@@ -383,6 +383,12 @@ func createDestinationRuleForLocal(remoteController *RemoteController, localDrNa
 	syncNamespace := common.GetSyncNamespace()
 	serviceInstance := getServiceForDeployment(remoteController, deploymentInstance)
 
+	serviceInstance = getServiceForDeployment(remoteController, deploymentInstance)
+	if serviceInstance == nil {
+		log.Warnf(LogFormatAdv, "Get", "Service", deploymentInstance.Name, deploymentInstance.Namespace, remoteController.ClusterID, "No matching service instance found")
+		return
+	}
+
 	cname := common.GetCname(deploymentInstance, common.GetHostnameSuffix(), common.GetWorkloadIdentifier())
 	if cname == destinationRule.Host {
 		destinationRule.Host = serviceInstance.Name + common.Sep + serviceInstance.Namespace + common.DotLocalDomainSuffix
@@ -688,6 +694,11 @@ func getServiceForDeployment(rc *RemoteController, deployment *k8sAppsV1.Deploym
 		return nil
 	}
 
+	if deployment.Spec.Selector == nil || deployment.Spec.Selector.MatchLabels == nil {
+		log.Infof("No selector for deployment=%s in namespace=%s and cluster=%s", deployment.Name, deployment.Namespace, rc.ClusterID)
+		return nil
+	}
+
 	cachedService := rc.ServiceController.Cache.Get(deployment.Namespace)
 
 	if cachedService == nil {
@@ -751,6 +762,12 @@ func getServiceForRollout(rc *RemoteController, rollout *argo.Rollout) map[strin
 	if rollout == nil {
 		return nil
 	}
+
+	if rollout.Spec.Selector == nil || rollout.Spec.Selector.MatchLabels == nil {
+		log.Infof("No selector for rollout=%s in namespace=%s and cluster=%s", rollout.Name, rollout.Namespace, rc.ClusterID)
+		return nil
+	}
+
 	cachedService := rc.ServiceController.Cache.Get(rollout.Namespace)
 
 	if cachedService == nil {
@@ -828,7 +845,6 @@ func getServiceForRollout(rc *RemoteController, rollout *argo.Rollout) map[strin
 
 	var matchedServices = make(map[string]*WeightedService)
 
-
 	//if we have more than one matching service we will pick the first one, for this to be deterministic we sort services
 	var servicesInNamespace = cachedService.Service[rollout.Namespace]